L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-61650 assign: More consistent empty text

Browse Source 
Consistently check for empty submissions with count_words(trim($text)).
This commit is contained in:
Damyon Wiese
2018-08-03 16:53:45 +08:00
parent a1d8976005
commit 5c4aef2664
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/submission/onlinetext/locallib.php
+13 -2
View File
@@ -575,8 +575,13 @@ class assign_submission_onlinetext extends assign_submission_plugin {
*/
public function is_empty(stdClass $submission) {
$onlinetextsubmission = $this->get_onlinetext_submission($submission->id);
$wordcount = 0;
return empty($onlinetextsubmission->onlinetext);
if (isset($onlinetextsubmission->onlinetext)) {
$wordcount = count_words(trim($onlinetextsubmission->onlinetext));
}
return $wordcount == 0;
}
/**
@@ -592,7 +597,13 @@ class assign_submission_onlinetext extends assign_submission_plugin {
if (!isset($data->onlinetext_editor)) {
return true;
}
return !strlen((string)$data->onlinetext_editor['text']);
$wordcount = 0;
if (isset($data->onlinetext_editor['text'])) {
$wordcount = count_words(trim((string)$data->onlinetext_editor['text']));
}
return $wordcount == 0;
}
/**