MDL-37943 upgrade: logic error in upgrade_plugins_blocks.

Derek Woolhead tracked down the problem and what needed to be fixed. I
just made the patch.

The problem was that if $plugin->cron had changed in version.php, then
the version number in the database could end up wrong after the upgrade,
and so the upgrade would immediately run a second time.
This commit is contained in:
Tim Hunt
2013-02-08 12:43:58 +00:00
parent 0e6d8bc952
commit 5baa26c105
+1 -2
View File
@@ -823,8 +823,7 @@ function upgrade_plugins_blocks($startcallback, $endcallback, $verbose) {
if ($currblock->cron != $block->cron) {
// update cron flag if needed
$currblock->cron = $block->cron;
$DB->update_record('block', $currblock);
$DB->set_field('block', 'cron', $block->cron, array('id' => $currblock->id));
}
// Upgrade various components