MDL-43281 Blocks: Retrieve a newly created block after creating it

Although we were previously creating the DOM markup for a block region if
it did not exist, we were not making use of it.

This change ensures that we make use of that block region as part of the
blocks code.

lib/yui/build/moodle-core-blocks/moodle-core-blocks-debug.js

@@ -802,7 +802,7 @@ BLOCKREGION.prototype = {
         Y.log('Block region `'+this.get('region')+'` initialising', 'info');
         if (!node) {
             Y.log('block region known about but no HTML structure found for it. Guessing structure.', 'warn');
-            this.create_and_add_node();
+            node = this.create_and_add_node();
         }
         var body = Y.one('body'),
             hasblocks = node.all('.'+CSS.BLOCK).size() > 0,
@@ -818,6 +818,7 @@ BLOCKREGION.prototype = {
      * Creates a generic block region node and adds it to the DOM at the best guess location.
      * Any calling of this method is an unfortunate circumstance.
      * @method create_and_add_node
+     * @return Node The newly created Node
      */
     create_and_add_node : function() {
         var c = Y.Node.create,
@@ -860,6 +861,8 @@ BLOCKREGION.prototype = {
             Y.one('body').append(node);
         }
         this.set('node', node);
+
+        return node;
     },
 
     /**

lib/yui/build/moodle-core-blocks/moodle-core-blocks.js

@@ -798,7 +798,7 @@ BLOCKREGION.prototype = {
     initializer : function() {
         var node = this.get('node');
         if (!node) {
-            this.create_and_add_node();
+            node = this.create_and_add_node();
         }
         var body = Y.one('body'),
             hasblocks = node.all('.'+CSS.BLOCK).size() > 0,
@@ -814,6 +814,7 @@ BLOCKREGION.prototype = {
      * Creates a generic block region node and adds it to the DOM at the best guess location.
      * Any calling of this method is an unfortunate circumstance.
      * @method create_and_add_node
+     * @return Node The newly created Node
      */
     create_and_add_node : function() {
         var c = Y.Node.create,
@@ -856,6 +857,8 @@ BLOCKREGION.prototype = {
             Y.one('body').append(node);
         }
         this.set('node', node);
+
+        return node;
     },
 
     /**

lib/yui/src/blocks/js/blockregion.js

@@ -27,7 +27,7 @@ BLOCKREGION.prototype = {
         Y.log('Block region `'+this.get('region')+'` initialising', 'info');
         if (!node) {
             Y.log('block region known about but no HTML structure found for it. Guessing structure.', 'warn');
-            this.create_and_add_node();
+            node = this.create_and_add_node();
         }
         var body = Y.one('body'),
             hasblocks = node.all('.'+CSS.BLOCK).size() > 0,
@@ -43,6 +43,7 @@ BLOCKREGION.prototype = {
      * Creates a generic block region node and adds it to the DOM at the best guess location.
      * Any calling of this method is an unfortunate circumstance.
      * @method create_and_add_node
+     * @return Node The newly created Node
      */
     create_and_add_node : function() {
         var c = Y.Node.create,
@@ -85,6 +86,8 @@ BLOCKREGION.prototype = {
             Y.one('body').append(node);
         }
         this.set('node', node);
+
+        return node;
     },
 
     /**