MDL-65044 core: add task for grade history cleanup

lang/en/admin.php

@@ -1234,6 +1234,7 @@ $string['taskfiletrashcleanup'] = 'Cleanup files in trash';
 $string['taskglobalsearchindex'] = 'Global search indexing';
 $string['taskglobalsearchoptimize'] = 'Global search index optimization';
 $string['taskgradecron'] = 'Background processing for gradebook';
+$string['taskgradehistorycleanup'] = 'Background processing for clean grade history tables';
 $string['tasklegacycron'] = 'Legacy cron processing for plugins';
 $string['tasklogcleanup'] = 'Cleanup of task logs';
 $string['tasklogs'] = 'Task logs';

lib/classes/task/grade_cron_task.php

@@ -85,17 +85,6 @@ class grade_cron_task extends scheduled_task {
             $gradegrade->update('locktime');
         }
         $rs->close();
-
-        // Cleanup history tables.
-        if (!empty($CFG->gradehistorylifetime)) {
-            $histlifetime = $now - ($CFG->gradehistorylifetime * DAYSECS);
-            $tables = array('grade_outcomes_history', 'grade_categories_history', 'grade_items_history', 'grade_grades_history', 'scale_history');
-            foreach ($tables as $table) {
-                if ($DB->delete_records_select($table, "timemodified < ?", array($histlifetime))) {
-                    mtrace("    Deleted old grade history records from '$table'");
-                }
-            }
-        }
     }
 
 }

lib/classes/task/grade_history_cleanup_task.php

@@ -0,0 +1,67 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * A scheduled task.
+ *
+ * @package    core
+ * @copyright  2019 Simey Lameze <[email protected]>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+namespace core\task;
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * Simple task to clean grade history tables.
+ *
+ * @copyright  2019 Simey Lameze <[email protected]>
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+class grade_history_cleanup_task extends scheduled_task {
+
+    /**
+     * Get a descriptive name for this task (shown to admins).
+     *
+     * @return string
+     */
+    public function get_name() {
+        return get_string('taskgradehistorycleanup', 'admin');
+    }
+
+    /**
+     * Cleanup history tables.
+     */
+    public function execute() {
+        global $CFG, $DB;
+
+        if (!empty($CFG->gradehistorylifetime)) {
+            $now = time();
+            $histlifetime = $now - ($CFG->gradehistorylifetime * DAYSECS);
+            $tables = [
+                'grade_outcomes_history',
+                'grade_categories_history',
+                'grade_items_history',
+                'grade_grades_history',
+                'scale_history'
+            ];
+            foreach ($tables as $table) {
+                if ($DB->delete_records_select($table, "timemodified < ?", [$histlifetime])) {
+                    mtrace("    Deleted old grade history records from '$table'");
+                }
+            }
+        }
+    }
+}

lib/db/tasks.php

@@ -149,6 +149,15 @@ $tasks = array(
         'dayofweek' => '*',
         'month' => '*'
     ),
+    array(
+        'classname' => 'core\task\grade_history_cleanup_task',
+        'blocking' => 0,
+        'minute' => '*',
+        'hour' => '0',
+        'day' => '*',
+        'dayofweek' => '*',
+        'month' => '*'
+    ),
     array(
         'classname' => 'core\task\completion_regular_task',
         'blocking' => 0,

version.php

@@ -29,7 +29,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$version  = 2019032200.00;              // YYYYMMDD      = weekly release date of this DEV branch.
+$version  = 2019032200.01;              // YYYYMMDD      = weekly release date of this DEV branch.
                                         //         RR    = release increments - 00 in DEV branches.
                                         //           .XX = incremental changes.