MDL-27625 rating - consider RATING_UNSET_RATING a valid rating value
This commit is contained in:
+7
-2
@@ -1420,9 +1420,14 @@ function data_rating_validate($params) {
|
||||
}
|
||||
|
||||
//check that the submitted rating is valid for the scale
|
||||
if ($params['rating'] < 0) {
|
||||
|
||||
// lower limit
|
||||
if ($params['rating'] < 0 && $params['rating'] != RATING_UNSET_RATING) {
|
||||
throw new rating_exception('invalidnum');
|
||||
} else if ($info->scale < 0) {
|
||||
}
|
||||
|
||||
// upper limit
|
||||
if ($info->scale < 0) {
|
||||
//its a custom scale
|
||||
$scalerecord = $DB->get_record('scale', array('id' => -$params['scaleid']));
|
||||
if ($scalerecord) {
|
||||
|
||||
+7
-2
@@ -3513,9 +3513,14 @@ function forum_rating_validate($params) {
|
||||
}
|
||||
|
||||
//check that the submitted rating is valid for the scale
|
||||
if ($params['rating'] < 0) {
|
||||
|
||||
// lower limit
|
||||
if ($params['rating'] < 0 && $params['rating'] != RATING_UNSET_RATING) {
|
||||
throw new rating_exception('invalidnum');
|
||||
} else if ($info->scale < 0) {
|
||||
}
|
||||
|
||||
// upper limit
|
||||
if ($info->scale < 0) {
|
||||
//its a custom scale
|
||||
$scalerecord = $DB->get_record('scale', array('id' => -$params['scaleid']));
|
||||
if ($scalerecord) {
|
||||
|
||||
@@ -526,9 +526,14 @@ function glossary_rating_validate($params) {
|
||||
}
|
||||
|
||||
//check that the submitted rating is valid for the scale
|
||||
if ($params['rating'] < 0) {
|
||||
|
||||
// lower limit
|
||||
if ($params['rating'] < 0 && $params['rating'] != RATING_UNSET_RATING) {
|
||||
throw new rating_exception('invalidnum');
|
||||
} else if ($info->scale < 0) {
|
||||
}
|
||||
|
||||
// upper limit
|
||||
if ($info->scale < 0) {
|
||||
//its a custom scale
|
||||
$scalerecord = $DB->get_record('scale', array('id' => -$params['scaleid']));
|
||||
if ($scalerecord) {
|
||||
|
||||
Reference in New Issue
Block a user