MDL-62643 assign: Skip empty online text files

Online text assignment submissions with no text entered into the editor should not
create a blank html document for providing feedback.
This commit is contained in:
Damyon Wiese
2018-06-15 14:13:21 +08:00
parent fd308528cd
commit 54e6ea018d
@@ -395,7 +395,9 @@ class assign_submission_onlinetext extends assign_submission_plugin {
$files = array();
$onlinetextsubmission = $this->get_onlinetext_submission($submission->id);
if ($onlinetextsubmission) {
// Note that this check is the same logic as the result from the is_empty function but we do
// not call it directly because we already have the submission record.
if ($onlinetextsubmission && !empty($onlinetextsubmission->onlinetext)) {
$finaltext = $this->assignment->download_rewrite_pluginfile_urls($onlinetextsubmission->onlinetext, $user, $this);
$formattedtext = format_text($finaltext,
$onlinetextsubmission->onlineformat,