L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-37459 admin: Fix for error on updating a locked checkbox

Browse Source 
Changed the way apply_admin_locked_flags gets the current value for the field.

The old way was plain wrong (looking at getValue from the quickform element).
This commit is contained in:
Damyon Wiese
2013-06-13 11:18:18 +10:00
committed by Marina Glancy
parent 19c1e0b80a
commit 54106942b3
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
course/moodleform_mod.php
+7 -2
View File
@@ -893,6 +893,7 @@ abstract class moodleform_mod extends moodleform {
$lockedicon = html_writer::tag('span',
$OUTPUT->pix_icon('t/locked', get_string('locked', 'admin')),
array('class' => 'action-icon'));
$isupdate = !empty($this->_cm);
foreach ($settings as $name => $value) {
if (strpos('_', $name) !== false) {
@@ -902,8 +903,12 @@ abstract class moodleform_mod extends moodleform {
$element = $mform->getElement($name);
$lockedsetting = $name . '_locked';
if (!empty($settings->$lockedsetting)) {
$value = $mform->getElement($name)->getValue();
$value = reset($value);
// Always lock locked settings for new modules,
// for updates, only lock them if the current value is the same as the default (or there is no current value).
$value = $settings->$name;
if ($isupdate && isset($this->current->$name)) {
$value = $this->current->$name;
}
if ($value == $settings->$name) {
$mform->setConstant($name, $settings->$name);
$element->setLabel($element->getLabel() . $lockedicon);