"MDL-14129, fix print_error"

course/mod.php

@@ -276,7 +276,7 @@ function get_cm($id, $error='cmunknown') {
     if (!$modname = $DB->get_field_sql("SELECT md.name
                                           FROM {course_modules} cm, {modules} md
                                          WHERE cm.id = ? AND md.id = cm.module", array($id))){
-        print_error($error);
+        print_error('cmunknown');
     }
 
     $cm = get_coursemodule_from_id($modname, $id);

course/modedit.php

@@ -248,7 +248,8 @@
                 print_error('cannotupdatemod', '', 'view.php?id=$course->id', $fromform->modulename);
             }
             if (is_string($returnfromfunc)) {
-                print_error($returnfromfunc, '', "view.php?id=$course->id");
+                //TODO: need more detailed error info
+                print_error('invalidfunction', '', 'view.php?id=$course->id');
             }
 
             set_coursemodule_visible($fromform->coursemodule, $fromform->visible);
@@ -283,7 +284,8 @@
                 print_error("cannotaddnewmodule", '', "view.php?id=$course->id", $fromform->modulename);
             }
             if (is_string($returnfromfunc)) {
-                print_error($returnfromfunc, '', "view.php?id=$course->id");
+                //TODO: need more detailed error info
+                print_error('invalidfunction', '', 'view.php?id=$course->id');
             }
 
             $fromform->instance = $returnfromfunc;

lang/en_utf8/error.php

@@ -236,6 +236,7 @@ $string['invalidfieldname'] = '\"$a\" is not a valid field name';
 $string['invalidfiletype'] = '\"$a\" is not a valid file type';
 $string['invalidformatpara'] = 'Incorrect format for choose parameter';
 $string['invalidformdata'] = 'Incorrect Form Data';
+$string['invalidfunction'] = 'Incorrect function';
 $string['invalidgradeitmeid'] = 'Incorrect grade item id';
 $string['invalidgroupid'] = 'Incorrect group id specified.';
 $string['invaliditemid'] = 'Incorect item id';