MDL-70137 cache: Write config to temp file and move into place

This commit is contained in:
Andrew Nicols
2020-11-06 19:16:51 +00:00
committed by Víctor Déniz
parent b26a5e5e08
commit 511dab1cd3
+4 -2
View File
@@ -102,13 +102,15 @@ class cache_config_writer extends cache_config {
$factory = cache_factory::instance();
$locking = $factory->create_lock_instance($lockconf);
if ($locking->lock('configwrite', 'config', true)) {
$tempcachefile = "{$cachefile}.tmp";
// Its safe to use w mode here because we have already acquired the lock.
$handle = fopen($cachefile, 'w');
$handle = fopen($tempcachefile, 'w');
fwrite($handle, $content);
fflush($handle);
fclose($handle);
$locking->unlock('configwrite', 'config');
@chmod($cachefile, $CFG->filepermissions);
@chmod($tempcachefile, $CFG->filepermissions);
rename($tempcachefile, $cachefile);
// Tell PHP to recompile the script.
core_component::invalidate_opcode_php_cache($cachefile);
} else {