MDL-63466 core_message: removed get_last_message_time_created_cache_key

lib/messagelib.php

@@ -295,8 +295,7 @@ function message_send(\core\message\message $eventdata) {
         if (!empty($eventdata->convid)) {
             // Cache the timecreated value of the last message in this conversation.
             $cache = cache::make('core', 'message_time_last_message_in_conversation');
-            $key = \core_message\helper::get_last_message_time_created_cache_key($eventdata->convid);
-            $cache->set($key, $tabledata->timecreated);
+            $cache->set($eventdata->convid, $tabledata->timecreated);
         }
     }
 

message/classes/api.php

@@ -617,9 +617,8 @@ class api {
             }
 
             // Check the cache to see if we even need to do a DB query.
-            $cache = \cache::make('core', 'message_time_last_message_between_users');
-            $key = helper::get_last_message_time_created_cache_key($conversationid);
-            $lastcreated = $cache->get($key);
+            $cache = \cache::make('core', 'message_time_last_message_in_conversation');
+            $lastcreated = $cache->get($conversationid);
 
             // The last known message time is earlier than the one being requested so we can
             // just return an empty result set rather than having to query the DB.
@@ -655,8 +654,7 @@ class api {
         if (!empty($timefrom)) {
             // Check the cache to see if we even need to do a DB query.
             $cache = \cache::make('core', 'message_time_last_message_in_conversation');
-            $key = helper::get_last_message_time_created_cache_key($convid);
-            $lastcreated = $cache->get($key);
+            $lastcreated = $cache->get($convid);
 
             // The last known message time is earlier than the one being requested so we can
             // just return an empty result set rather than having to query the DB.

message/classes/helper.php

@@ -439,16 +439,6 @@ class helper {
         return sha1(implode('-', $userids));
     }
 
-    /**
-     * Returns the cache key for the time created value of the last message of this conversation.
-     *
-     * @param int $convid The conversation identifier.
-     * @return string The key.
-     */
-    public static function get_last_message_time_created_cache_key(int $convid) {
-        return $convid;
-    }
-
     /**
      * Checks if legacy messages exist for a given user.
      *