MDL-76597 mod_quiz: Set presentation role for the question list

Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.
The aria-label for the <li> element is inappropriate and can also cause
confusion to screen reader users. Better to remove this. Though this is
being used in the confirmation modal so better to just change it to a
data attribute.

mod/quiz/classes/output/edit_renderer.php

@@ -404,8 +404,8 @@ class edit_renderer extends \plugin_renderer_base {
         }
 
         $output .= html_writer::start_tag('li', array('id' => 'section-'.$section->id,
-            'class' => 'section main clearfix'.$sectionstyle, 'role' => 'region',
-            'aria-label' => $sectionheadingtext));
+            'class' => 'section main clearfix'.$sectionstyle, 'role' => 'presentation',
+            'data-sectionname' => $sectionheadingtext));
 
         $output .= html_writer::start_div('content');
 

mod/quiz/yui/build/moodle-mod_quiz-toolboxes/moodle-mod_quiz-toolboxes-debug.js

@@ -929,7 +929,7 @@ Y.extend(SECTIONTOOLBOX, TOOLBOX, {
 
         // Create the confirmation dialogue.
         var confirm = new M.core.confirm({
-            question: M.util.get_string('confirmremovesectionheading', 'quiz', activity.get('aria-label')),
+            question: M.util.get_string('confirmremovesectionheading', 'quiz', activity.getData('sectionname')),
             modal: true
         });
 

mod/quiz/yui/build/moodle-mod_quiz-toolboxes/moodle-mod_quiz-toolboxes.js

@@ -929,7 +929,7 @@ Y.extend(SECTIONTOOLBOX, TOOLBOX, {
 
         // Create the confirmation dialogue.
         var confirm = new M.core.confirm({
-            question: M.util.get_string('confirmremovesectionheading', 'quiz', activity.get('aria-label')),
+            question: M.util.get_string('confirmremovesectionheading', 'quiz', activity.getData('sectionname')),
             modal: true
         });
 

mod/quiz/yui/src/toolboxes/js/section.js

@@ -113,7 +113,7 @@ Y.extend(SECTIONTOOLBOX, TOOLBOX, {
 
         // Create the confirmation dialogue.
         var confirm = new M.core.confirm({
-            question: M.util.get_string('confirmremovesectionheading', 'quiz', activity.get('aria-label')),
+            question: M.util.get_string('confirmremovesectionheading', 'quiz', activity.getData('sectionname')),
             modal: true
         });