MDL-50670 course: apply defaults when format was switched

2017-05-05 14:52:08 +08:00
parent c68568541f
commit 4d3595e7af
1 changed files with 3 additions and 1 deletions
@@ -678,7 +678,9 @@ abstract class format_base {
            if (isset($option['type'])) {
                $mform->setType($optionname, $option['type']);
            }
-            if (is_null($mform->getElementValue('id')) && isset($option['default'])) {
+            if (isset($option['default']) && !array_key_exists($optionname, $mform->_defaultValues)) {
+                // Set defaults for the elements in the form.
+                // Since we call this method after set_data() make sure that we don't override what was already set.
                $mform->setDefault($optionname, $option['default']);
            }
        }