Merge branch 'MDL-70648-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE

calendar/classes/local/event/forms/create.php

@@ -128,6 +128,7 @@ class create extends \moodleform {
         $eventtype = isset($data['eventtype']) ? $data['eventtype'] : null;
         $coursekey = ($eventtype == 'group') ? 'groupcourseid' : 'courseid';
         $courseid = (!empty($data[$coursekey])) ? $data[$coursekey] : null;
+        $categoryid = (!empty($data['categoryid'])) ? $data['categoryid'] : null;
 
         $eventtypes = $this->_customdata['eventtypes'];
         if (empty($eventtype) || !isset($eventtypes[$eventtype]) || $eventtypes[$eventtype] == false) {
@@ -148,6 +149,10 @@ class create extends \moodleform {
             $errors['courseid'] = get_string('selectacourse');
         }
 
+        if ($eventtype == 'category' && empty($categoryid)) {
+            $errors['categoryid'] = get_string('selectacategory');
+        }
+
         if ($eventtype == 'group' && (!empty($courseid) && empty($data['groupid']))) {
             $errors['groupcourseid'] = get_string('nogroups', 'core_group');
         }

lib/db/upgrade.php

@@ -3017,5 +3017,11 @@ function xmldb_main_upgrade($oldversion) {
         upgrade_main_savepoint(true, 2020110900.01);
     }
 
+    if ($oldversion < 2020110901.03) {
+        $DB->delete_records_select('event', "eventtype = 'category' AND categoryid = 0 AND userid <> 0");
+
+        upgrade_main_savepoint(true, 2020110901.03);
+    }
+
     return true;
 }

version.php

@@ -29,7 +29,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$version  = 2020110901.02;              // 20201109      = branching date YYYYMMDD - do not modify!
+$version  = 2020110901.03;              // 20201109      = branching date YYYYMMDD - do not modify!
                                         //         RR    = release increments - 00 in DEV branches.
                                         //           .XX = incremental changes.
 $release  = '3.10.1+ (Build: 20210130)';// Human-friendly version name