L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

accesslib: simplify and speedup create_context()

Browse Source 
Callers _must_ do their homework before calling create_context().
This allows us to save 2/3 queries per call (!!!).

As it stands, callers are all in accesslib anyway.
This commit is contained in:
martinlanghoff
2007-09-19 07:12:56 +00:00
parent 3d3def3a4e
commit 4881f2d329
1 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/accesslib.php
+15 -20
View File
@@ -1964,34 +1964,29 @@ function islegacy($capabilityname) {
/**
* Create a new context record for use by all roles-related stuff
* assumes that the caller has done the homework.
*
* @param $level
* @param $instanceid
*
* @return object newly created context (or existing one with a debug warning)
*/
function create_context($contextlevel, $instanceid) {
if (!$context = get_record('context','contextlevel',$contextlevel,'instanceid',$instanceid)) {
if (!validate_context($contextlevel, $instanceid)) {
debugging('Error: Invalid context creation request for level "'.s($contextlevel).'", instance "'.s($instanceid).'".');
return NULL;
}
if ($contextlevel == CONTEXT_SYSTEM) {
return create_system_context();
if ($contextlevel == CONTEXT_SYSTEM) {
return create_system_context();
}
}
$context = new object();
$context->contextlevel = $contextlevel;
$context->instanceid = $instanceid;
if ($id = insert_record('context',$context)) {
$c = get_record('context','id',$id);
return $c;
} else {
debugging('Error: could not insert new context level "'.s($contextlevel).'", instance "'.s($instanceid).'".');
return NULL;
}
$context = new object();
$context->contextlevel = $contextlevel;
$context->instanceid = $instanceid;
if ($id = insert_record('context',$context)) {
$c = get_record('context','id',$id);
return $c;
} else {
debugging('Warning: Context id "'.s($context->id).'" not created, because it already exists.');
return $context;
debugging('Error: could not insert new context level "'.
s($contextlevel).'", instance "'.
s($instanceid).'".');
return NULL;
}
}