MDL-66108 course: fix false positives when bulk moving categories.

2020-01-17 16:19:07 +00:00
parent fd126006b0
commit 47ff771e80
1 changed files with 2 additions and 1 deletions
@@ -316,7 +316,8 @@ if ($action !== false && confirm_sesskey()) {
                        $notificationsfail[] = get_string('movecategoryownparent', 'error', $cattomove->get_formatted_name());
                        continue;
                    }
-                    if (strpos($movetocat->path, $cattomove->path) === 0) {
+                    // Don't allow user to move selected category into one of it's own sub-categories.
+                    if (strpos($movetocat->path, $cattomove->path . '/') === 0) {
                        $notificationsfail[] = get_string('movecategoryparentconflict', 'error', $cattomove->get_formatted_name());
                        continue;
                    }