L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-53443 mod_feedback: fix SQL statment to work on all DB

Browse Source
This commit is contained in:
Marina Glancy
2016-04-13 12:00:14 +08:00
parent 1d981ae4c2
commit 47f4909a08
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/feedback/analysis_course.php
+1 -5
View File
@@ -110,11 +110,7 @@ if (is_array($items)) {
}
if ($courseitemfilter > 0) {
$avgvalue = 'avg(value)';
if ($DB->get_dbfamily() == 'postgres') { // TODO: this should be moved to standard sql DML function ;-)
$avgvalue = 'avg(cast (value as integer))';
}
$avgvalue = 'avg(' . $DB->sql_cast_char2int('value', true) . ')';
$sql = "SELECT fv.course_id, c.shortname, $avgvalue AS avgvalue
FROM {feedback_value} fv, {course} c, {feedback_item} fi
WHERE fv.course_id = c.id AND fi.id = fv.item AND fi.typ = ? AND fv.item = ?