L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-16567 "Quiz statistics report does not work when the quiz contains descriptions" slightly more elegant and efficient solution to issue.

Browse Source
This commit is contained in:
jamiesensei
2008-09-19 10:12:54 +00:00
parent 3695cfa93f
commit 452351550b
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/report/statistics/qstats.php
+3 -7
View File
@@ -38,6 +38,7 @@ class qstats{
}
function get_records($quizid, $currentgroup, $groupstudents, $allattempts){
global $DB;
list($qsql, $qparams) = $DB->get_in_or_equal(array_keys($this->questions), SQL_PARAMS_NAMED, 'q0000');
list($fromqa, $whereqa, $qaparams) = quiz_report_attempts_sql($quizid, $currentgroup, $groupstudents, $allattempts);
$sql = 'SELECT qs.id, ' .
'qs.question, ' .
@@ -49,18 +50,13 @@ class qstats{
'{question_states} qs, '.
$fromqa.' '.
'WHERE ' .$whereqa.
'AND qs.question '.$qsql.' '.
'AND qns.attemptid = qa.uniqueid '.
'AND qns.newgraded = qs.id';
$this->states = $DB->get_records_sql($sql, $qaparams);
$this->states = $DB->get_records_sql($sql, $qaparams + $qparams);
if ($this->states === false){
print_error('errorstatisticsquestions', 'quiz_statistics');
}
// Nasty hack fix for MDL-16567 - TODO a proper fix.
foreach ($this->states as $id => $state) {
if (!isset($this->questions[$state->question])) {
unset($this->states[$id]);
}
}
}
function _initial_states_walker($state, &$stats, $positionstat = true){