L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-12517 null not treated properly, max instead of min typo and pretty please initialize all objects properly

Browse Source
This commit is contained in:
skodak
2007-12-18 13:26:30 +00:00
parent 5b6219a750
commit 44e65ebf62
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/report/grader/lib.php
+5 -2
View File
@@ -199,15 +199,18 @@ class grade_report_grader extends grade_report {
$finalgrade = unformat_float($postedvalue);
}
// Warn if the grade is out of bounds.
$errorstr = '';
if ($finalgrade < $grade_item->grademax) {
// Warn if the grade is out of bounds.
if (is_null($finalgrade)) {
// ok
} else if ($finalgrade < $grade_item->grademin) {
$errorstr = 'lessthanmin';
} else if ($finalgrade > $grade_item->grademax) {
$errorstr = 'morethanmax';
}
if ($errorstr) {
$user = get_record('user', 'id', $userid,'','','','','id, firstname, lastname');
$gradestr = new object();
$gradestr->username = fullname($user);
$gradestr->itemname = $grade_item->get_name();
notify(get_string($errorstr, 'grades', $gradestr));