L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-52930 forum: Fix random test failure caused by passing of time

Browse Source
This commit is contained in:
Andrew Nicols
2016-02-10 12:24:45 +08:00
committed by David Monllao
parent b292fa181c
commit 4339f877d4
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/forum/tests/lib_test.php
+8 -5
View File
@@ -1852,18 +1852,21 @@ class mod_forum_lib_testcase extends advanced_testcase {
$user = $this->getDataGenerator()->create_user();
$forumgen = $this->getDataGenerator()->get_plugin_generator('mod_forum');
// Keep track of the start time of the test. Do not use time() after this point to prevent random failures.
$time = time();
$record = new stdClass();
$record->course = $course->id;
$record->userid = $user->id;
$record->forum = $forum->id;
if (isset($discussiondata['timecreated'])) {
$record->timemodified = time() + $discussiondata['timecreated'];
$record->timemodified = $time + $discussiondata['timecreated'];
}
if (isset($discussiondata['timestart'])) {
$record->timestart = time() + $discussiondata['timestart'];
$record->timestart = $time + $discussiondata['timestart'];
}
if (isset($discussiondata['timeend'])) {
$record->timeend = time() + $discussiondata['timeend'];
$record->timeend = $time + $discussiondata['timeend'];
}
if (isset($discussiondata['mailed'])) {
$record->mailed = $discussiondata['mailed'];
@@ -1872,7 +1875,7 @@ class mod_forum_lib_testcase extends advanced_testcase {
$discussion = $forumgen->create_discussion($record);
// Fetch the unmailed posts.
$timenow = time();
$timenow = $time;
$endtime = $timenow - $CFG->maxeditingtime;
$starttime = $endtime - 2 * DAYSECS;
@@ -1886,7 +1889,7 @@ class mod_forum_lib_testcase extends advanced_testcase {
$reply->discussion = $discussion->id;
$reply->parent = $replyto->id;
$reply->created = max($replyto->created, $endtime - 1);
$r = $forumgen->create_post($reply);
$forumgen->create_post($reply);
$unmailed = forum_get_unmailed_posts($starttime, $endtime, $timenow);
$this->assertCount($expectedreplycount, $unmailed);