L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-24058 fixed sql injection, addslashes must not be used any more

Browse Source
This commit is contained in:
Petr Skoda
2010-09-02 12:16:24 +00:00
parent 7d8f881a49
commit 4287c1c2a0
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/report/spamcleaner/index.php
+8 -6
View File
@@ -148,19 +148,21 @@ function search_spammers($keywords) {
$keywords = array($keywords); // Make it into an array
}
$like = $DB->sql_ilike();
$like = $DB->sql_ilike();
$params = array('userid'=>$USER->id);
$keywordfull = array();
foreach ($keywords as $keyword) {
$keyword = addslashes($keyword); // Just to be safe
$keywordfull[] = " description $like '%$keyword%' ";
$keywordfull2[] = " p.summary $like '%$keyword%' ";
$keywordfull[] = " description $like :descpat ";
$params['descpat'] = "%$keyword%";
$keywordfull2[] = " p.summary $like :sumpat ";
$params['sumpat'] = "%$keyword%";
}
$conditions = '( '.implode(' OR ', $keywordfull).' )';
$conditions2 = '( '.implode(' OR ', $keywordfull2).' )';
$sql = "SELECT * FROM {user} WHERE deleted = 0 AND id <> {$USER->id} AND $conditions"; // Exclude oneself
$sql2= "SELECT u.*, p.summary FROM {user} AS u, {post} AS p WHERE $conditions2 AND u.deleted = 0 AND u.id=p.userid AND u.id <> {$USER->id}";
$sql = "SELECT * FROM {user} WHERE deleted = 0 AND id <> :userid AND $conditions"; // Exclude oneself
$sql2 = "SELECT u.*, p.summary FROM {user} AS u, {post} AS p WHERE $conditions2 AND u.deleted = 0 AND u.id=p.userid AND u.id <> :userid";
$spamusers_desc = $DB->get_recordset_sql($sql);
$spamusers_blog = $DB->get_recordset_sql($sql2);