MDL-59467 core: Use hasHelper instead of catching exception

When xdebug is set to break on exceptions it stops on all exceptions,
including _caught_ exceptions.

As a result we regularly hit this uniqid helper issue if debugging with
xdebug.

The solution is to check if the helper exists using the hasHelper method
instead of catching an exception when it does not exist.
This commit is contained in:
Andrew Nicols
2023-12-19 09:20:51 +08:00
parent bc6e29023b
commit 40966eedaa
+2 -2
View File
@@ -181,10 +181,10 @@ class renderer_base {
public function render_from_template($templatename, $context) {
$mustache = $this->get_mustache();
try {
if ($mustache->hasHelper('uniqid')) {
// Grab a copy of the existing helper to be restored later.
$uniqidhelper = $mustache->getHelper('uniqid');
} catch (Mustache_Exception_UnknownHelperException $e) {
} else {
// Helper doesn't exist.
$uniqidhelper = null;
}