administration MDL-21351 revert changes

admin/settings.php

@@ -126,9 +126,7 @@ if (empty($SITE->fullname)) {
 
     echo $settingspage->output_html();
 
-    if ($settingspage->displaysavebutton) {
-        echo '<div class="form-buttons"><input class="form-submit" type="submit" value="'.get_string('savechanges','admin').'" /></div>';
-    }
+    echo '<div class="form-buttons"><input class="form-submit" type="submit" value="'.get_string('savechanges','admin').'" /></div>';
 
     echo '</div>';
     echo '</form>';

admin/settings/plugins.php

@@ -239,7 +239,6 @@ if ($hassiteconfig) {
 /// Web services
     $ADMIN->add('modules', new admin_category('webservicesettings', get_string('webservices', 'webservice')));
     $temp = new admin_settingpage('externalservices', get_string('externalservices', 'webservice'));
-    $temp->hidesavebutton();
     $temp->add(new admin_setting_heading('manageserviceshelpexplaination', get_string('information', 'webservice'), get_string('servicehelpexplanation', 'webservice')));
     $temp->add(new admin_setting_manageexternalservices());
     $ADMIN->add('webservicesettings', $temp);
@@ -248,7 +247,6 @@ if ($hassiteconfig) {
     $ADMIN->add('webservicesettings', new admin_externalpage('externalserviceusers', get_string('externalserviceusers', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/service_users.php", 'moodle/site:config', true));
     /// manage protocol page link
     $temp = new admin_settingpage('webserviceprotocols', get_string('manageprotocols', 'webservice'));
-    $temp->hidesavebutton();
     $temp->add(new admin_setting_managewebserviceprotocols());
     if (empty($CFG->enablewebservices)) {
         $temp->add(new admin_setting_heading('webservicesaredisabled', '', get_string('disabledwarning', 'webservice')));
@@ -271,7 +269,6 @@ if ($hassiteconfig) {
     /// manage token page link
     $ADMIN->add('webservicesettings', new admin_externalpage('addwebservicetoken', get_string('managetokens', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/tokens.php", 'moodle/site:config', true));
     $temp = new admin_settingpage('webservicetokens', get_string('managetokens', 'webservice'));
-    $temp->hidesavebutton();
     $temp->add(new admin_setting_managewebservicetokens());
     if (empty($CFG->enablewebservices)) {
         $temp->add(new admin_setting_heading('webservicesaredisabled', '', get_string('disabledwarning', 'webservice')));

lib/adminlib.php

@@ -1005,9 +1005,6 @@ class admin_settingpage implements part_of_admin_tree {
     public $path;
     public $visiblepath;
 
-    /** display the save changes button **/
-    public $displaysavebutton;
-
     /**
      * see admin_settingpage for details of this function
      *
@@ -1029,7 +1026,6 @@ class admin_settingpage implements part_of_admin_tree {
         }
         $this->hidden      = $hidden;
         $this->context     = $context;
-        $this->displaysavebutton = true;
     }
 
     /**
@@ -1052,13 +1048,6 @@ class admin_settingpage implements part_of_admin_tree {
         }
     }
 
-    /**
-     * Hide the Save Changes button
-     */
-    public function hidesavebutton() {
-       $this->displaysavebutton = false;
-    }
-
     /**
      * Search string in settings page.
      *