Fixed Bug #5057 - hidden teachers aren't completely hidden

This commit is contained in:
vyshane
2006-04-10 08:49:15 +00:00
parent b525bd2009
commit 3f763c86cf
+11 -4
View File
@@ -82,14 +82,21 @@ class block_online_users extends block_base {
}
}
if ($teachers = get_records_sql("SELECT u.id, u.username, u.firstname, u.lastname, u.picture, u.lastaccess, s.timeaccess
$findteacherssql = "SELECT u.id, u.username, u.firstname, u.lastname, u.picture, u.lastaccess, s.timeaccess
FROM {$CFG->prefix}user u,
{$CFG->prefix}user_teachers s
$groupmembers
WHERE u.id = s.userid $courseselect $groupselect $timeselect
ORDER BY s.timeaccess DESC")) {
WHERE u.id = s.userid $courseselect $groupselect $timeselect ";
if (!isteacher($course->id)) {
// Hide hidden teachers from students.
$findteacherssql .= 'AND s.authority > 0 ';
}
$findteacherssql .= 'ORDER BY s.timeaccess DESC';
if ($teachers = get_records_sql($findteacherssql)) {
foreach ($teachers as $teacher) {
$teacher->fullname = '<b>'.fullname($teacher).'</b>';
$teacher->fullname = '<strong>'.fullname($teacher).'</strong>';
$users[$teacher->id] = $teacher;
}
}