MDL-67307 core: Fix onject creation from empty value cases
The "creating default object from empty value" warning is now consistently thrown if a falsy value is promoted into an stdClass object. Previously some cases like `$null->prop[0] = $val` missed this warning.
This commit is contained in:
committed by
Jake Dallimore
parent
006ec3c96f
commit
3eac4851e3
@@ -3251,6 +3251,9 @@ class initials_bar implements renderable, templatable {
|
||||
if ($letter == $this->current) {
|
||||
$groupletter->selected = $this->current;
|
||||
}
|
||||
if (!isset($data->group[$groupnumber])) {
|
||||
$data->group[$groupnumber] = new stdClass();
|
||||
}
|
||||
$data->group[$groupnumber]->letter[] = $groupletter;
|
||||
}
|
||||
|
||||
|
||||
@@ -2485,6 +2485,8 @@ class assign {
|
||||
* @return array An array of userids
|
||||
*/
|
||||
protected function get_grading_userid_list($cached = false, $useridlistid = '') {
|
||||
global $SESSION;
|
||||
|
||||
if ($cached) {
|
||||
if (empty($useridlistid)) {
|
||||
$useridlistid = $this->get_useridlist_key_id();
|
||||
|
||||
Reference in New Issue
Block a user