MDL-36157 block_rss_client: Don't double escape titles.

blocks/rss_client/block_rss_client.php

@@ -273,9 +273,9 @@
     function format_title($title,$max=64) {
 
         if (core_text::strlen($title) <= $max) {
-            return s($title);
+            return $title;
         } else {
-            return s(core_text::substr($title,0,$max-3).'...');
+            return core_text::substr($title, 0, $max - 3) . '...';
         }
     }
 

blocks/rss_client/managefeeds.php

@@ -106,7 +106,7 @@ foreach($feeds as $feed) {
     if (!empty($feed->preferredtitle)) {
         $feedtitle = s($feed->preferredtitle);
     } else {
-        $feedtitle =  s($feed->title);
+        $feedtitle = $feed->title;
     }
 
     $viewlink = html_writer::link($CFG->wwwroot .'/blocks/rss_client/viewfeed.php?rssid=' . $feed->id . $extraparams, $feedtitle);