L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-12858 fix course category depths during upgrade to 1.9

Browse Source
This commit is contained in:
skodak
2007-12-19 17:47:31 +00:00
parent 40f43aa1fc
commit 3e1f8e095c
2 changed files with 49 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/db/upgrade.php
+1 -4
View File
@@ -2055,10 +2055,7 @@ function xmldb_main_upgrade($oldversion=0) {
$result = $result && create_table($table);
/// make sure category depths, parents and paths are ok, categories from 1.5 may not be properly initialized (MDL-12585)
$sql = "UPDATE {$CFG->prefix}course_categories
SET depth = 1, parent = 0, path = ".sql_concat("'/'", "id")."
WHERE depth = 0 OR parent = 0";
execute_sql($sql);
upgrade_fix_category_depths();
/// Recalculate depths, paths and so on
if (!empty($CFG->rolesactive)) {
lib/db/upgradelib.php
+48
View File
@@ -514,4 +514,52 @@ function upgrade_18_groups_drop_keys_indexes() {
return $result;
}
function upgrade_fix_category_depths() {
global $CFG, $db;
// first fix incorrect parents
$sql = "SELECT c.id
FROM {$CFG->prefix}course_categories c
WHERE c.parent > 0 AND c.parent NOT IN (SELECT pc.id FROM {$CFG->prefix}course_categories pc)";
if ($rs = get_recordset_sql($sql)) {
while ($cat = rs_fetch_next_record($rs)) {
$cat->depth = 1;
$cat->path = '/'.$cat->id;
$cat->parent = 0;
update_record('course_categories', $cat);
}
rs_close($rs);
}
// now add path and depth to top level categories
$sql = "UPDATE {$CFG->prefix}course_categories
SET depth = 1, path = ".sql_concat("'/'", "id")."
WHERE parent = 0";
execute_sql($sql);
// now fix all other levels - slow but works in all supported dbs
$parentdepth = 1;
$db->debug = true;
while (record_exists('course_categories', 'depth', 0)) {
$sql = "SELECT c.id, pc.path
FROM {$CFG->prefix}course_categories c, {$CFG->prefix}course_categories pc
WHERE c.parent=pc.id AND c.depth=0 AND pc.depth=$parentdepth";
if ($rs = get_recordset_sql($sql)) {
while ($cat = rs_fetch_next_record($rs)) {
$cat->depth = $parentdepth+1;
$cat->path = $cat->path.'/'.$cat->id;
update_record('course_categories', $cat);
}
rs_close($rs);
}
$parentdepth++;
if ($parentdepth > 100) {
//something must have gone wrong - nobody can have more than 100 levels of categories, right?
debugging('Unknown error fixing category depths');
break;
}
}
$db->debug = true;
}
?>