MDL-58948 behat: Fix timeouts without a condition
The second parameter of the wait method should be a string so passing boolean false was wrong. The default on for the script is 'false' which works cross Mink drivers.
This commit is contained in:
@@ -66,7 +66,7 @@ class behat_block_comments extends behat_base {
|
||||
$this->find_link(get_string('savecomment'))->click();
|
||||
// Delay after clicking so that additional comments will have unique time stamps.
|
||||
// We delay 1 second which is all we need.
|
||||
$this->getSession()->wait(1000, false);
|
||||
$this->getSession()->wait(1000);
|
||||
|
||||
} else {
|
||||
|
||||
@@ -104,7 +104,7 @@ class behat_block_comments extends behat_base {
|
||||
);
|
||||
|
||||
// Wait for the animation to finish, in theory is just 1 sec, adding 4 just in case.
|
||||
$this->getSession()->wait(4 * 1000, false);
|
||||
$this->getSession()->wait(4 * 1000);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -1830,7 +1830,7 @@ class behat_course extends behat_base {
|
||||
$node->click();
|
||||
|
||||
// Smooth expansion.
|
||||
$this->getSession()->wait(1000, false);
|
||||
$this->getSession()->wait(1000);
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -143,7 +143,7 @@ class behat_general extends behat_base {
|
||||
|
||||
// Wait until the URL change is executed.
|
||||
if ($this->running_javascript()) {
|
||||
$this->getSession()->wait($waittime * 1000, false);
|
||||
$this->getSession()->wait($waittime * 1000);
|
||||
|
||||
} else if (!empty($url)) {
|
||||
// We redirect directly as we can not wait for an automatic redirection.
|
||||
@@ -253,7 +253,7 @@ class behat_general extends behat_base {
|
||||
*/
|
||||
public function i_wait_seconds($seconds) {
|
||||
if ($this->running_javascript()) {
|
||||
$this->getSession()->wait($seconds * 1000, false);
|
||||
$this->getSession()->wait($seconds * 1000);
|
||||
} else {
|
||||
sleep($seconds);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user