L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29325 Enrol : reduced isset calls and improved readability

Browse Source
This commit is contained in:
Aparup Banerjee
2011-12-13 16:36:49 +08:00
parent 903ab24de4
commit 3b89933d9f
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enrol/imsenterprise/lib.php
+5 -3
View File
@@ -359,14 +359,16 @@ function process_group_tag($tagcontents) {
$this->log_line("Course $coursecode not found in Moodle's course idnumbers.");
} else {
// Set shortname to description or description to shortname if one is set but not the other.
if (!isset($group->description) && !isset($group->shortName)) {
$nodescription = !isset($group->description);
$noshortname = !isset($group->shortname);
if ( $nodescription && $noshortname) {
// If neither short nor long description are set let if fail
$this->log_line("Neither long nor short name are set for $coursecode");
} else if (!isset($group->description)) {
} else if ($nodescription) {
// If short and ID exist, then give the long short's value, then give short the ID's value
$group->description = $group->shortName;
$group->shortName = $coursecode;
} else if (!isset($group->shortName)) {
} else if ($noshortname) {
// If long and ID exist, then map long to long, then give short the ID's value.
$group->shortName = $coursecode;
}