L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-42919 Assign: Remove no-label form hacks

Browse Source
This commit is contained in:
Damyon Wiese
2013-11-26 13:30:36 +08:00
parent 4d4b345392
commit 3a5c3b3cbf
5 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/feedback/comments/locallib.php
+1 -2
View File
@@ -203,8 +203,7 @@ class assign_feedback_comments extends assign_feedback_plugin {
}
}
$mform->addElement('editor', 'assignfeedbackcomments_editor', html_writer::tag('span', $this->get_name(),
array('class' => 'accesshide')), null, null);
$mform->addElement('editor', 'assignfeedbackcomments_editor', $this->get_name(), null, null);
return true;
}
mod/assign/feedback/file/locallib.php
+1 -2
View File
@@ -143,8 +143,7 @@ class assign_feedback_file extends assign_feedback_plugin {
'assignfeedback_file',
ASSIGNFEEDBACK_FILE_FILEAREA,
$gradeid);
$mform->addElement('filemanager', $elementname . '_filemanager', html_writer::tag('span', $this->get_name(),
array('class' => 'accesshide')), null, $fileoptions);
$mform->addElement('filemanager', $elementname . '_filemanager', $this->get_name(), null, $fileoptions);
return true;
}
mod/assign/locallib.php
+2 -9
View File
@@ -944,11 +944,7 @@ class assign {
protected function add_plugin_grade_elements($grade, MoodleQuickForm $mform, stdClass $data, $userid) {
foreach ($this->feedbackplugins as $plugin) {
if ($plugin->is_enabled() && $plugin->is_visible()) {
$mform->addElement('header', 'header_' . $plugin->get_type(), $plugin->get_name());
$mform->setExpanded('header_' . $plugin->get_type());
if (!$plugin->get_form_elements_for_user($grade, $mform, $data, $userid)) {
$mform->removeElement('header_' . $plugin->get_type());
}
$plugin->get_form_elements_for_user($grade, $mform, $data, $userid);
}
}
}
@@ -5720,10 +5716,7 @@ class assign {
$userid) {
foreach ($this->submissionplugins as $plugin) {
if ($plugin->is_enabled() && $plugin->is_visible() && $plugin->allow_submissions()) {
$mform->addElement('header', 'header_' . $plugin->get_type(), $plugin->get_name());
if (!$plugin->get_form_elements_for_user($submission, $mform, $data, $userid)) {
$mform->removeElement('header_' . $plugin->get_type());
}
$plugin->get_form_elements_for_user($submission, $mform, $data, $userid);
}
}
}
mod/assign/submission/file/locallib.php
+1 -2
View File
@@ -158,8 +158,7 @@ class assign_submission_file extends assign_submission_plugin {
'assignsubmission_file',
ASSIGNSUBMISSION_FILE_FILEAREA,
$submissionid);
$mform->addElement('filemanager', 'files_filemanager', html_writer::tag('span', $this->get_name(),
array('class' => 'accesshide')), null, $fileoptions);
$mform->addElement('filemanager', 'files_filemanager', $this->get_name(), null, $fileoptions);
return true;
}
mod/assign/submission/onlinetext/locallib.php
+1 -2
View File
@@ -95,8 +95,7 @@ class assign_submission_onlinetext extends assign_submission_plugin {
'assignsubmission_onlinetext',
ASSIGNSUBMISSION_ONLINETEXT_FILEAREA,
$submissionid);
$mform->addElement('editor', 'onlinetext_editor', html_writer::tag('span', $this->get_name(),
array('class' => 'accesshide')), null, $editoroptions);
$mform->addElement('editor', 'onlinetext_editor', $this->get_name(), null, $editoroptions);
return true;
}