L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-42495 lesson Prevent coding error for invalid user

Browse Source
This commit is contained in:
Michael Aherne
2014-01-20 13:22:14 +08:00
committed by Damyon Wiese
parent be34306a60
commit 386cd5a24c
1 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lesson/essay.php
+6 -17
View File
@@ -268,23 +268,12 @@ switch ($mode) {
$ufields = user_picture::fields('u');
list($sort, $sortparams) = users_order_by_sql('u');
$params = array_merge($params, $sortparams);
if (!empty($cm->groupingid)) {
$params["groupingid"] = $cm->groupingid;
$sql = "SELECT DISTINCT $ufields
FROM {lesson_attempts} a
INNER JOIN {user} u ON u.id = a.userid
INNER JOIN {groups_members} gm ON gm.userid = u.id
INNER JOIN {groupings_groups} gg ON gm.groupid = gg.groupid AND gg.groupingid = :groupingid
WHERE a.lessonid = :lessonid
ORDER BY $sort";
} else {
$sql = "SELECT DISTINCT $ufields
FROM {user} u,
{lesson_attempts} a
WHERE a.lessonid = :lessonid and
u.id = a.userid
ORDER BY $sort";
}
$sql = "SELECT DISTINCT $ufields
FROM {user} u,
{lesson_attempts} a
WHERE a.lessonid = :lessonid and
u.id = a.userid
ORDER BY $sort";
if (!$users = $DB->get_records_sql($sql, $params)) {
$mode = 'none'; // not displaying anything
$lesson->add_message(get_string('noonehasanswered', 'lesson'));