MDL-47494 ddmarker: Merge pull request #17 from jamiepratt/wip_js_fix

Wip js fix
2012-08-08 04:14:33 -07:00
parent 2da2c6d949 701baddf73
commit 34632b52d6
1 changed files with 5 additions and 7 deletions
@@ -423,16 +423,14 @@ YUI.add('moodle-qtype_ddmarker-dd', function(Y) {
                }
            }, this);
            if (this.graphics !== null) {
-                var oldshapes = this.graphics.get('shapes');
-                for (var id in oldshapes) {
-                    oldshapes[id].destroy();
-                }
-            }
-            if (this.get('dropzones').length !== 0) {
-                this.restart_colours();
+                this.graphics.clear();
+            } else {
                this.graphics = new Y.Graphic(
                    {render:this.doc.top_node().one("div.ddarea div.dropzones")}
                );
+            }
+            if (this.get('dropzones').length !== 0) {
+                this.restart_colours();
                for (var dropzoneno in this.get('dropzones')) {
                    var colourfordropzone = this.get_next_colour();
                    var d = this.get('dropzones')[dropzoneno];