MDL-40935 phpunit: Remove assertLegacyEventName() since get_legacy_eventname() is public now

lib/phpunit/classes/advanced_testcase.php

@@ -338,21 +338,6 @@ abstract class advanced_testcase extends PHPUnit_Framework_TestCase {
         $this->assertEquals($expected, $legacydata, $message);
     }
 
-    /**
-     * Assert that an event legacy name is equal to the expected value.
-     *
-     * @param mixed $expected expected name.
-     * @param \core\event\base $event the event object.
-     * @param string $message
-     * @return void
-     */
-    public function assertEventLegacyName($expected, \core\event\base $event, $message = '') {
-        $legacydata = phpunit_event_mock::testable_get_legacy_eventname($event);
-        if ($message === '') {
-            $message = 'Event legacy name does not match expected value.';
-        }
-        $this->assertEquals($expected, $legacydata, $message);
-    }
 
     /**
      * Starts message redirection.

lib/phpunit/classes/event_mock.php

@@ -35,14 +35,6 @@ require_once(__DIR__ . '/../../classes/event/base.php');
  */
 abstract class phpunit_event_mock extends \core\event\base {
 
-    /**
-     * Returns the log data of the event.
-     * @return array
-     */
-    public static function testable_get_legacy_eventname($event) {
-        return $event->get_legacy_eventname();
-    }
-
     /**
      * Returns the log data of the event.
      * @return array

lib/tests/accesslib_test.php

@@ -486,7 +486,7 @@ class core_accesslib_testcase extends advanced_testcase {
         $this->assertEquals($raid, $event->other['id']);
         $this->assertSame('', $event->other['component']);
         $this->assertEquals(0, $event->other['itemid']);
-        $this->assertEventLegacyName('role_assigned', $event);
+        $this->assertSame('role_assigned', $event::get_legacy_eventname());
     }
 
     /**