MDL-32323 undo path mangling, we have to trust admins

2012-04-10 15:27:07 +02:00
parent 6c583c75f9
commit 31fb8724f6
1 changed files with 2 additions and 3 deletions
@@ -131,9 +131,8 @@ if ($execute) {
        }
    }
    $configdir = escapeshellarg($configdir);
-    // cleanup the path - this is tricky because we can not use quotes for escaping
-    $path = escapeshellcmd($path);
-    $path = str_replace('\*', '*', $path);
+    // no cleanup of path - this is tricky because we can not use escapeshellarg and friends for escaping,
+    // this is from admin user so PARAM_PATH must be enough
    chdir($CFG->dirroot);
    passthru("php $CFG->admin/tool/phpunit/cli/util.php --run -c $configdir $path", $code);
    chdir($oldcwd);