MDL-47930 mod_forum: Display all forum statuses correctly
It is possible for users with the mod/forum:managesubscriptions to subscribe to forums with subscription disabled. This is handled by forum_get_subscribe_link() already and should have been handled here all along.
This commit is contained in:
+6
-14
@@ -266,13 +266,9 @@ if ($generalforums) {
|
||||
}
|
||||
|
||||
if ($can_subscribe) {
|
||||
if ($forum->forcesubscribe != FORUM_DISALLOWSUBSCRIBE) {
|
||||
$row[] = forum_get_subscribe_link($forum, $context, array('subscribed' => $stryes,
|
||||
'unsubscribed' => $strno, 'forcesubscribed' => $stryes,
|
||||
'cantsubscribe' => '-'), false, false, true, $subscribed_forums);
|
||||
} else {
|
||||
$row[] = '-';
|
||||
}
|
||||
$row[] = forum_get_subscribe_link($forum, $context, array('subscribed' => $stryes,
|
||||
'unsubscribed' => $strno, 'forcesubscribed' => $stryes,
|
||||
'cantsubscribe' => '-'), false, false, true);
|
||||
|
||||
$digestoptions_selector->url->param('id', $forum->id);
|
||||
if ($forum->maildigest === null) {
|
||||
@@ -416,13 +412,9 @@ if ($course->id != SITEID) { // Only real courses have learning forums
|
||||
}
|
||||
|
||||
if ($can_subscribe) {
|
||||
if ($forum->forcesubscribe != FORUM_DISALLOWSUBSCRIBE) {
|
||||
$row[] = forum_get_subscribe_link($forum, $context, array('subscribed' => $stryes,
|
||||
'unsubscribed' => $strno, 'forcesubscribed' => $stryes,
|
||||
'cantsubscribe' => '-'), false, false, true, $subscribed_forums);
|
||||
} else {
|
||||
$row[] = '-';
|
||||
}
|
||||
$row[] = forum_get_subscribe_link($forum, $context, array('subscribed' => $stryes,
|
||||
'unsubscribed' => $strno, 'forcesubscribed' => $stryes,
|
||||
'cantsubscribe' => '-'), false, false, true, $subscribed_forums);
|
||||
|
||||
$digestoptions_selector->url->param('id', $forum->id);
|
||||
if ($forum->maildigest === null) {
|
||||
|
||||
Reference in New Issue
Block a user