Merging from STABLE:
Fix for bug 3510: Due to stupidly copy/pasting some code, deleting a block instance could, under some circumstances, throw a fatal error.
This commit is contained in:
+3
-2
@@ -185,10 +185,10 @@ function blocks_delete_instance($instance) {
|
||||
|
||||
// Get the block object and call instance_delete() first
|
||||
if(!$record = blocks_get_record($instance->blockid)) {
|
||||
continue;
|
||||
return false;
|
||||
}
|
||||
if(!$obj = block_instance($record->name, $instance)) {
|
||||
continue;
|
||||
return false;
|
||||
}
|
||||
|
||||
// Return value ignored
|
||||
@@ -200,6 +200,7 @@ function blocks_delete_instance($instance) {
|
||||
execute_sql('UPDATE '.$CFG->prefix.'block_instance SET weight = weight - 1 WHERE pagetype = \''.$instance->pagetype.
|
||||
'\' AND pageid = '.$instance->pageid.' AND position = \''.$instance->position.
|
||||
'\' AND weight > '.$instance->weight, false);
|
||||
return true;
|
||||
}
|
||||
|
||||
// Accepts an array of block instances and checks to see if any of them have content to display
|
||||
|
||||
Reference in New Issue
Block a user