L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-57021 passwords: only use unmask field with shared secrets

Browse Source 
When a user is entering a password which isn't returned back to them
then its not correct to use the unmask element - this element was
designed for places where we are storing shared secrets.
This commit is contained in:
Dan Poltawski
2017-07-05 12:25:41 +02:00
committed by Eloy Lafuente (stronk7)
parent a3aa1600de
commit 2dc0dc6293
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enrol/guest/locallib.php
+1 -1
View File
@@ -38,7 +38,7 @@ class enrol_guest_enrol_form extends moodleform {
$heading = $plugin->get_instance_name($instance);
$mform->addElement('header', 'guestheader', $heading);
$mform->addElement('passwordunmask', 'guestpassword', get_string('password', 'enrol_guest'));
$mform->addElement('password', 'guestpassword', get_string('password', 'enrol_guest'));
$this->add_action_buttons(false, get_string('submit'));
enrol/self/locallib.php
+1 -1
View File
@@ -78,7 +78,7 @@ class enrol_self_enrol_form extends moodleform {
if ($instance->password) {
// Change the id of self enrolment key input as there can be multiple self enrolment methods.
$mform->addElement('passwordunmask', 'enrolpassword', get_string('password', 'enrol_self'),
$mform->addElement('password', 'enrolpassword', get_string('password', 'enrol_self'),
array('id' => 'enrolpassword_'.$instance->id));
$context = context_course::instance($this->instance->courseid);
$keyholders = get_users_by_capability($context, 'enrol/self:holdkey', user_picture::fields('u'));
login/signup_form.php
+1 -1
View File
@@ -46,7 +46,7 @@ class login_signup_form extends moodleform implements renderable, templatable {
if (!empty($CFG->passwordpolicy)){
$mform->addElement('static', 'passwordpolicyinfo', '', print_password_policy());
}
$mform->addElement('passwordunmask', 'password', get_string('password'), 'maxlength="32" size="12"');
$mform->addElement('password', 'password', get_string('password'), 'maxlength="32" size="12"');
$mform->setType('password', core_user::get_property_type('password'));
$mform->addRule('password', get_string('missingpassword'), 'required', null, 'client');