L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-84723 behat: final improvements and fixes to the test

Browse Source 
This commit does few things:
- Remove unnecessary grade field to assign generator.
- Remove unnecessary comment lines.
- Update the warning message assertion to use the no-break space unicode character.
This commit is contained in:
Simey Lameze
2025-03-06 11:24:16 +08:00
parent 78a04159cd
commit 2cee750fdf
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/grading/form/guide/tests/behat/guide_max_grade_mismatch.feature
+4 -8
View File
@@ -16,12 +16,10 @@ Feature: Marking guide can handle maximum grade mismatches
| teacher1 | C1 | editingteacher |
Scenario Outline: Marking guide maximum grade handling
# Set the maximum total grade for assignment to 100.
Given the following "activities" exist:
| activity | course | name | advancedgradingmethod_submissions | grade[modgrade_point] |
| assign | C1 | Assign 1 | guide | 100 |
| activity | course | name | advancedgradingmethod_submissions |
| assign | C1 | Assign 1 | guide |
And I am on the "Course 1" course page logged in as teacher1
# Create marking guide.
And I go to "Assign 1" advanced grading definition page
And I set the following fields to these values:
| Name | Assign 1 marking guide |
@@ -31,11 +29,9 @@ Feature: Marking guide can handle maximum grade mismatches
| Grade Criteria 1 | Grade 1 description for students | Grade 1 description for markers | <maxscore> |
| Grade Criteria 2 | Grade 2 description for students | Grade 2 description for markers | 30 |
When I press "Save marking guide and make it ready"
# Confirm that marking guide is successfully set as ready.
Then I should see "Assign 1 marking guide Ready for use"
# The corresponding warning message that grades will be scaled is displayed.
And I should see "WARNING: Your marking guide has a maximum grade of <totalmaxscore> points"
And I should see "but the maximum grade set in your activity is 100 The maximum score set in your marking guide will be scaled to the maximum grade in the module."
# Please note: We need to add the no-break space unicode character to the warning message otherwise it will fail.
And I should see "WARNING: Your marking guide has a maximum grade of <totalmaxscore> points but the maximum grade set in your activity is 100 The maximum score set in your marking guide will be scaled to the maximum grade in the module."
And I should see "Intermediate scores will be converted respectively and rounded to the nearest available grade."
Examples: