L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-74802 core: Remove tooltip on the notification close button

Browse Source 
Reverting the addition of a Boostrap tooltip on the alert notification's
close button. It introduced a bug where the tooltip remains after
dismissing the notification alert. We can manually toggle the state of
the tooltip via JS, but I don't think it's worth the effort. The tooltip
is meant as an added bonus for sighted users to see what the close
button is about.
This commit is contained in:
Jun Pataleta
2022-06-10 13:15:32 +02:00
committed by Sara Arjona
parent 42d214d0cc
commit 2c58871a74
4 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/templates/notification_error.mustache
+1 -2
View File
@@ -41,8 +41,7 @@
}}>
{{{ message }}}
{{# closebutton }}{{!
}}<button type="button" class="close" data-dismiss="alert"{{!
}} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
}}<button type="button" class="close" data-dismiss="alert">
<span aria-hidden="true">&times;</span>
<span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
</button>{{!
lib/templates/notification_info.mustache
+1 -2
View File
@@ -41,8 +41,7 @@
}}>
{{{ message }}}
{{# closebutton }}{{!
}}<button type="button" class="close" data-dismiss="alert"{{!
}} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
}}<button type="button" class="close" data-dismiss="alert">
<span aria-hidden="true">&times;</span>
<span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
</button>{{!
lib/templates/notification_success.mustache
+1 -2
View File
@@ -41,8 +41,7 @@
}}>
{{{ message }}}
{{# closebutton }}{{!
}}<button type="button" class="close" data-dismiss="alert"{{!
}} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
}}<button type="button" class="close" data-dismiss="alert">
<span aria-hidden="true">&times;</span>
<span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
</button>{{!
lib/templates/notification_warning.mustache
+1 -2
View File
@@ -41,8 +41,7 @@
}}>
{{{ message }}}
{{# closebutton }}{{!
}}<button type="button" class="close" data-dismiss="alert"{{!
}} title="{{#str}}dismissnotification, core{{/str}}" data-toggle="tooltip">
}}<button type="button" class="close" data-dismiss="alert">
<span aria-hidden="true">&times;</span>
<span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
</button>{{!