L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-83143: core_communication: Fix variable name typos

Browse Source
This commit is contained in:
Safat
2024-10-11 11:02:07 +11:00
parent d7e3bea9fa
commit 2c363085af
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
communication/classes/helper.php
+9 -9
View File
@@ -431,13 +431,13 @@ class helper {
if (empty($provider)) {
$provider = $coursecommunication->get_provider();
}
$roomnameidenfier = $provider . 'roomname';
$roomnameidentifier = $provider . 'roomname';
// Determine the communication room name if none was provided and add it to the course data.
if (empty($course->$roomnameidenfier)) {
$course->$roomnameidenfier = $coursecommunication->get_room_name();
if (empty($course->$roomnameidenfier)) {
$course->$roomnameidenfier = $course->fullname ?? get_course($course->id)->fullname;
if (empty($course->$roomnameidentifier)) {
$course->$roomnameidentifier = $coursecommunication->get_room_name();
if (empty($course->$roomnameidentifier)) {
$course->$roomnameidentifier = $course->fullname ?? get_course($course->id)->fullname;
}
}
@@ -470,7 +470,7 @@ class helper {
$communication->configure_room_and_membership_by_provider(
provider: $provider,
instance: $course,
communicationroomname: $course->$roomnameidenfier,
communicationroomname: $course->$roomnameidentifier,
users: $enrolledusers,
instanceimage: $courseimage,
);
@@ -491,7 +491,7 @@ class helper {
$communication->configure_room_and_membership_by_provider(
provider: $provider,
instance: $course,
communicationroomname: $course->$roomnameidenfier,
communicationroomname: $course->$roomnameidentifier,
users: $enrolledusers,
instanceimage: $courseimage,
queue: false,
@@ -542,9 +542,9 @@ class helper {
context: $coursecontext,
);
$roomnameidenfier = $provider . 'roomname';
$roomnameidentifier = $provider . 'roomname';
$communicationroomname = self::format_group_room_name(
baseroomname: $course->$roomnameidenfier,
baseroomname: $course->$roomnameidentifier,
groupname: $coursegroup->name,
);
communication/tests/api_test.php
+2 -2
View File
@@ -69,10 +69,10 @@ class api_test extends \advanced_testcase {
// Set the data.
$communication->set_data($course);
$roomnameidenfier = $communication->get_provider() . 'roomname';
$roomnameidentifier = $communication->get_provider() . 'roomname';
// Test the set data.
$this->assertEquals($roomname, $course->$roomnameidenfier);
$this->assertEquals($roomname, $course->$roomnameidentifier);
$this->assertEquals($provider, $course->selectedcommunication);
}