L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-35547 Detect loops in question categories.

Browse Source
This commit is contained in:
Tomasz Muras
2012-09-30 19:29:53 +02:00
parent 24d9d1811f
commit 2ade1b52f9
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/questionlib.php
+16 -8
View File
@@ -1179,16 +1179,24 @@ function question_add_tops($categories, $pcontexts) {
function question_categorylist($categoryid) {
global $DB;
$subcategories = $DB->get_records('question_categories',
array('parent' => $categoryid), 'sortorder ASC', 'id, 1');
//final list of category IDs
$categorylist = array();
$categorylist = array($categoryid);
foreach ($subcategories as $subcategory) {
if($subcategory->id == $categoryid)
//prevent infinite loop
throw new coding_exception("Question category $categoryid points to itself as a parent.");
//a list of category IDs to check for any sub-categories
$templist = array($categoryid);
while ($current = array_shift($templist)) {
if (isset($categorylist[$current])) {
throw new coding_exception("Category id=$current is already on the list - loop of categories detected.");
}
$categorylist = array_merge($categorylist, question_categorylist($subcategory->id));
$subcategories = $DB->get_records('question_categories',
array('parent' => $current), 'sortorder ASC', 'id, 1');
foreach ($subcategories as $subcategory) {
$templist[] = $subcategory->id;
}
$categorylist[$current] = $current;
}
return $categorylist;