L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-87019-redis-bloat-MOODLE_500_STABLE' of https://github.com/bwalkerl/moodle into MOODLE_500_STABLE

Browse Source
This commit is contained in:
Huong Nguyen
2025-11-06 10:35:11 +07:00
parent cfa5f8a60d 2530e564b1
commit 2ab3f1088f
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/classes/session/redis.php
+12 -5
View File
@@ -580,7 +580,9 @@ class redis extends handler implements SessionHandlerInterface {
if ($keys['timecreated'] != $keys['timemodified']) {
$maxlifetime = $this->get_maxlifetime($userid);
$this->connection->expire($this->sessionkeyprefix . $id, $maxlifetime);
$this->connection->expire($this->userkeyprefix . $userid, $maxlifetime);
if ($userid != 0) {
$this->connection->expire($this->userkeyprefix . $userid, $maxlifetime);
}
}
} catch (RedisException | RedisClusterException $e) {
error_log('Failed talking to redis: '.$e->getMessage());
@@ -615,9 +617,12 @@ class redis extends handler implements SessionHandlerInterface {
'lastip' => getremoteaddr(),
];
$userhashkey = $this->userkeyprefix . $userid;
$this->connection->hSet($userhashkey, $sid, $timestamp);
$this->connection->expire($userhashkey, $maxlifetime);
// Do not manage store mapping from user to sid for non-login user (0).
if ($userid != 0) {
$userhashkey = $this->userkeyprefix . $userid;
$this->connection->hSet($userhashkey, $sid, $timestamp);
$this->connection->expire($userhashkey, $maxlifetime);
}
$sessionhashkey = $this->sessionkeyprefix . $sid;
$this->connection->hmSet($sessionhashkey, $sessiondata);
@@ -664,7 +669,9 @@ class redis extends handler implements SessionHandlerInterface {
// Update the expiry time.
$maxlifetime = $this->get_maxlifetime($record->userid);
$this->connection->expire($sessionhashkey, $maxlifetime);
$this->connection->expire($userhashkey, $maxlifetime);
if ($record->userid != 0) {
$this->connection->expire($userhashkey, $maxlifetime);
}
return true;
}