L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-67683 theme: Do not use section for #region-main

Browse Source 
The #region-main container should not be a <section> tag (which has a
default landmark role of "region") as it contains the container with
the "main" role which should be a top-level landmark.

Read more at:
https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
This commit is contained in:
Jun Pataleta
2025-02-03 15:54:49 +08:00
parent 07881a5772
commit 29f452307d
9 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
theme/boost/templates/columns1.mustache
+2 -2
View File
@@ -48,7 +48,7 @@
<div id="page" class="container-fluid d-print-block">
<div id="page-content" class="row pb-3 d-print-block">
<div id="region-main-box" class="col-12">
<section id="region-main" aria-label="{{#str}}content{{/str}}">
<div id="region-main">
{{{ output.course_content_header }}}
{{#headercontent}}
{{> core/activity_header }}
@@ -56,7 +56,7 @@
{{{ output.main_content }}}
{{{ output.activity_navigation }}}
{{{ output.course_content_footer }}}
</section>
</div>
</div>
</div>
</div>
theme/boost/templates/columns2.mustache
+2 -2
View File
@@ -73,7 +73,7 @@
<div> {{{ regionmainsettingsmenu }}} </div>
</div>
{{/hasregionmainsettingsmenu}}
<section id="region-main" {{#hasblocks}}class="has-blocks mb-3"{{/hasblocks}} aria-label="{{#str}}content{{/str}}">
<div id="region-main" {{#hasblocks}}class="has-blocks mb-3"{{/hasblocks}}>
{{#hasregionmainsettingsmenu}}
<div class="region_main_settings_menu_proxy"></div>
@@ -89,7 +89,7 @@
{{{ output.activity_navigation }}}
{{{ output.course_content_footer }}}
</section>
</div>
{{#hasblocks}}
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
{{{ addblockbutton }}}
theme/boost/templates/drawers.mustache
+2 -2
View File
@@ -142,7 +142,7 @@
<div> {{{ regionmainsettingsmenu }}} </div>
</div>
{{/hasregionmainsettingsmenu}}
<section id="region-main" aria-label="{{#str}}content{{/str}}">
<div id="region-main">
{{#hasregionmainsettingsmenu}}
<div class="region_main_settings_menu_proxy"></div>
@@ -162,7 +162,7 @@
{{{ output.activity_navigation }}}
{{{ output.course_content_footer }}}
</section>
</div>
</div>
</div>
</div>
theme/boost/templates/login.mustache
+2 -2
View File
@@ -41,13 +41,13 @@
<div id="page" class="container-fluid pt-5 mt-0">
<div id="page-content" class="row">
<div id="region-main-box" class="col-12">
<section id="region-main" class="col-12 h-100" aria-label="{{#str}}content{{/str}}">
<div id="region-main" class="col-12 h-100">
<div class="login-wrapper">
<div class="login-container">
{{{ output.main_content }}}
</div>
</div>
</section>
</div>
</div>
</div>
</div>
theme/boost/templates/maintenance.mustache
+2 -2
View File
@@ -57,9 +57,9 @@
</div>
<div id="page-content" class="row">
<section id="region-main" class="col-12" aria-label="{{#str}}content{{/str}}">
<div id="region-main" class="col-12">
{{{ output.main_content }}}
</section>
</div>
</div>
</div>
theme/boost/templates/secure.mustache
+2 -2
View File
@@ -60,7 +60,7 @@
<div id="page-content" class="row">
<div id="region-main-box" class="col-12">
<section id="region-main" {{#hasblocks}}class="has-blocks"{{/hasblocks}} aria-label="{{#str}}content{{/str}}">
<div id="region-main" {{#hasblocks}}class="has-blocks"{{/hasblocks}}>
{{{ output.course_content_header }}}
{{#headercontent}}
@@ -69,7 +69,7 @@
{{{ output.main_content }}}
{{{ output.course_content_footer }}}
</section>
</div>
{{#hasblocks}}
<section data-region="blocks-column" aria-label="{{#str}}blocks{{/str}}">
{{{ sidepreblocks }}}
theme/classic/templates/columns.mustache
+2 -2
View File
@@ -66,7 +66,7 @@
<div> {{{ output.region_main_settings_menu }}} </div>
</div>
{{/hasregionmainsettingsmenu}}
<section id="region-main" class="region-main-content" aria-label="{{#str}}content{{/str}}">
<div id="region-main" class="region-main-content">
{{#hasregionmainsettingsmenu}}
<div class="region_main_settings_menu_proxy"></div>
{{/hasregionmainsettingsmenu}}
@@ -77,7 +77,7 @@
{{{ output.main_content }}}
{{{ output.activity_navigation }}}
{{{ output.course_content_footer }}}
</section>
</div>
</div>
<div class="columnleft blockcolumn {{#haspreblocks}} has-blocks {{/haspreblocks}}">
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
theme/classic/templates/contentonly.mustache
+2 -2
View File
@@ -54,7 +54,7 @@
<div id="page" class="container-fluid">
<div id="page-content" class="row">
<div id="region-main-box" class="col-12">
<section id="region-main" aria-label="{{#str}}content{{/str}}">
<div id="region-main">
{{{ output.course_content_header }}}
{{#headercontent}}
{{> core/activity_header }}
@@ -62,7 +62,7 @@
{{{ output.main_content }}}
{{{ output.activity_navigation }}}
{{{ output.course_content_footer }}}
</section>
</div>
</div>
</div>
</div>
theme/classic/templates/secure.mustache
+2 -2
View File
@@ -71,7 +71,7 @@
<div id="page-content" class="row {{#haspreblocks}} blocks-pre {{/haspreblocks}} {{#haspostblocks}} blocks-post {{/haspostblocks}}">
<div id="region-main-box" class="region-main">
<section id="region-main" aria-label="{{#str}}content{{/str}}">
<div id="region-main">
<div class="card">
<div class="card-body">
{{{ output.course_content_header }}}
@@ -82,7 +82,7 @@
{{{ output.course_content_footer }}}
</div>
</div>
</section>
</div>
</div>
<div class="columnleft {{#haspreblocks}} has-blocks {{/haspreblocks}}">
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">