MDL-78673 grade: Address random failure due to toast

grade/tests/behat/behat_grades.php

@@ -49,6 +49,58 @@ class behat_grades extends behat_base {
         ];
     }
 
+    /**
+     * Convert page names to URLs for steps like 'When I am on the "[identifier]" "[page type]" page'.
+     *
+     * Recognised page names are:
+     * | pagetype              | name meaning | description                                       |
+     * | [report] view         | Course name  | The view page for the specified course and report |
+     *
+     * @param string $type identifies which type of page this is - for example "Grader > View"
+     * @param string $identifier identifies the particular page - for example "Course name"
+     * @return moodle_url the corresponding URL.
+     */
+    protected function resolve_page_instance_url(string $type, string $identifier): moodle_url {
+        $type = strtolower($type);
+        if (strpos($type, '>') !== false) {
+            [$pluginname, $type] = explode('>', $type);
+            $pluginname = strtolower(trim($pluginname));
+
+            // Fetch the list of plugins.
+            $plugins = \core_component::get_plugin_list('gradereport');
+
+            if (array_key_exists($pluginname, $plugins)) {
+                $plugin = $pluginname;
+            } else {
+                $plugins = array_combine(
+                    array_keys($plugins),
+                    array_keys($plugins),
+                );
+
+                // This plugin is not in the list of plugins. Check the pluginname string.
+                $names = array_map(fn($name) => strtolower(get_string('pluginname', "gradereport_{$name}")), $plugins);
+                $result = array_search($pluginname, $names);
+                if ($result === false) {
+                    throw new \coding_exception("Unknown plugin '{$pluginname}'");
+                }
+                $plugin = $result;
+            }
+        }
+        $type = trim($type);
+
+        switch ($type) {
+            case 'view':
+                return new moodle_url(
+                    "/grade/report/{$plugin}/index.php",
+                    ['id' => $this->get_course_id($identifier)]
+                );
+            default:
+                throw new \coding_exception(
+                    "Unknown page type '$type' for page identifier '$identifier'"
+                );
+        }
+    }
+
     /**
      * Select a given element within a specific container instance.
      *

grade/tests/behat/grade_average.feature

@@ -50,15 +50,11 @@ Feature: Average grades are displayed in the gradebook
 
   Scenario: Grade a grade item and ensure the results display correctly in the gradebook
     # Check the admin grade table
-    And I navigate to "View > Grader report" in the course gradebook
+    Given I am on the "Course 1" "grades > Grader report > View" page logged in as "admin"
     Then I should see "50.00" in the ".avg.r0.lastrow .c1" "css_element"
     Then I should see "50.00" in the ".avg.r0.lastrow .c2" "css_element"
-    And I log out
 
     # Check the user grade table
-    And I log in as "student1"
-    And I am on "Course 1" course homepage
-    And I navigate to "User report" in the course gradebook
+    When I am on the "Course 1" "grades > user > View" page logged in as "student1"
     Then I should see "50.00" in the ".level2.column-grade" "css_element"
     Then I should see "50.00" in the ".level2.column-average" "css_element"
-    And I log out