L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-74318 core_user: Description field as hidden on profile

Browse Source
This commit is contained in:
Amaia Anabitarte
2022-04-08 12:44:17 +02:00
committed by Jenkins
parent 7e24859635
commit 27723d2ec9
3 changed files with 63 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
user/profile.php
+4
View File
@@ -198,6 +198,10 @@ profile_view($user, $usercontext);
echo $OUTPUT->header();
echo '<div class="userprofile">';
$hiddenfields = [];
if (!has_capability('moodle/user:viewhiddendetails', $usercontext)) {
$hiddenfields = array_flip(explode(',', $CFG->hiddenuserfields));
}
if ($user->description && !isset($hiddenfields['description'])) {
echo '<div class="description">';
if (!empty($CFG->profilesforenrolledusersonly) && !$currentuser &&
user/tests/behat/hidden_user_fields.feature
+55
View File
@@ -0,0 +1,55 @@
@core @core_user
Feature: Hidden user fields behavior
In order to hide private information of users
As an admin
I can set Hide user fields setting
Background:
Given the following "users" exist:
| username | firstname | lastname | email | description | city |
| user | Profile | User | user@example.com | This is me | Donostia |
| student | Student | User | student@example.com | | |
| teacher | Teacher | User | teacher@example.com | | |
And the following "courses" exist:
| fullname | shortname | format |
| Course 1 | C1 | topics |
And the following "course enrolments" exist:
| user | course | role |
| user | C1 | student |
| student | C1 | student |
| teacher | C1 | editingteacher |
And the following config values are set as admin:
| hiddenuserfields | description,email |
Scenario Outline: Hidden user fields on course context profile based on role permission
Given I log in as "<user>"
And I am on "Course 1" course homepage
And I navigate to course participants
And I should see "Profile User"
When I click on "Profile User" "link"
Then I <expected> "This is me"
And I <expected> "user@example.com"
And I should see "Donostia"
Examples:
| user | expected |
| student | should not see |
| teacher | should see |
| admin | should see |
Scenario Outline: Hidden user fields on system context profile based on role permission
Given I log in as "<user>"
And I am on "Course 1" course homepage
And I navigate to course participants
And I should see "Profile User"
When I click on "Profile User" "link"
And I click on "Full profile" "link"
Then I <expected> "This is me"
And I <expected> "user@example.com"
And I should see "Donostia"
Examples:
| user | expected |
| student | should not see |
| teacher | should not see |
| admin | should see |
user/view.php
+4
View File
@@ -193,6 +193,10 @@ if ($user->deleted) {
// Trigger a user profile viewed event.
profile_view($user, $coursecontext, $course);
$hiddenfields = [];
if (!has_capability('moodle/user:viewhiddendetails', $coursecontext)) {
$hiddenfields = array_flip(explode(',', $CFG->hiddenuserfields));
}
if ($user->description && !isset($hiddenfields['description'])) {
echo '<div class="description">';
if (!empty($CFG->profilesforenrolledusersonly) && !$DB->record_exists('role_assignments', array('userid' => $id))) {