L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

user MDL-16706 Elimate inline scripts, replaced with PAGE methods, created user.js

Browse Source
This commit is contained in:
samhemelryk
2009-07-02 04:02:40 +00:00
parent e1524dbe5c
commit 25a2bfda22
2 changed files with 23 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
user/index.php
+2 -31
View File
@@ -635,33 +635,7 @@
if ($bulkoperations) {
echo '
<script type="text/javascript">
//<![CDATA[
function checksubmit(form) {
var destination = form.formaction.options[form.formaction.selectedIndex].value;
if (destination == "" || !checkchecked(form)) {
form.formaction.selectedIndex = 0;
return false;
} else {
return true;
}
}
function checkchecked(form) {
var inputs = document.getElementsByTagName(\'INPUT\');
var checked = false;
inputs = filterByParent(inputs, function() {return form;});
for(var i = 0; i < inputs.length; ++i) {
if (inputs[i].type == \'checkbox\' && inputs[i].checked) {
checked = true;
}
}
return checked;
}
//]]>
</script>
';
$PAGE->requires->js('user/user.js');
echo '<form action="action_redir.php" method="post" id="participantsform" onsubmit="return checksubmit(this);">';
echo '<div>';
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
@@ -879,10 +853,7 @@
echo '<input type="hidden" name="id" value="'.$course->id.'" />';
echo '<div id="noscriptparticipantsform" style="display: inline;">';
echo '<input type="submit" value="'.get_string('ok').'" /></div>';
echo '<script type="text/javascript">'.
"\n//<![CDATA[\n".
'document.getElementById("noscriptparticipantsform").style.display = "none";'.
"\n//]]>\n".'</script>';
$PAGE->requires->js_function_call('hide_item', Array('noscriptparticipantsform'));
echo '</div>';
echo '</div>';
echo '</form>';
user/user.js
+21
View File
@@ -0,0 +1,21 @@
function checksubmit(form) {
var destination = form.formaction.options[form.formaction.selectedIndex].value;
if (destination == "" || !checkchecked(form)) {
form.formaction.selectedIndex = 0;
return false;
} else {
return true;
}
}
function checkchecked(form) {
var inputs = document.getElementsByTagName(\'INPUT\');
var checked = false;
inputs = filterByParent(inputs, function() {return form;});
for(var i = 0; i < inputs.length; ++i) {
if (inputs[i].type == \'checkbox\' && inputs[i].checked) {
checked = true;
}
}
return checked;
}