reverting moved $SITE reinitialisation into setting method, it was not a good idea after all; merged from MOODLE_17_STABLE

admin/settings.php

@@ -78,7 +78,8 @@ if ($data = data_submitted()) {
     } else {
         error(get_string('confirmsesskeybad', 'error'));
     }
-    //update $COURSE to match changed $SITE
+    // now update $SITE - it might have been changed
+    $SITE = get_record('course', 'id', $SITE->id);
     $COURSE = clone($SITE);
 }
 

lib/adminlib.php

@@ -1693,10 +1693,7 @@ class admin_setting_sitesettext extends admin_setting_configtext {
         $record->id = $this->id;
         $record->{$this->name} = $data;
         $record->timemodified = time();
-        $status = update_record('course', $record) ? '' : get_string('errorsetting', 'admin') . $this->visiblename . '<br />';
-        //now update $SITE
-        global $SITE;
-        $SITE = get_record('course', 'id', $SITE->id);
+        return (update_record('course', $record) ? '' : get_string('errorsetting', 'admin') . $this->visiblename . '<br />');
     }
 
 }