L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-69964 course: toggle participant checkboxes in root element.

Browse Source 
For a given toggleGroup, the relevant action elements are not
necessarily descendants of the same tableRoot element, on the
course participants page.
This commit is contained in:
Paul Holden
2020-11-16 17:44:23 +00:00
parent ec58cefefb
commit 22df02089a
4 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
user/amd/build/participants.min.js
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
user/amd/build/participants.min.js.map
+1 -1
View File
File diff suppressed because one or more lines are too long
user/amd/src/participants.js
+2 -2
View File
@@ -125,7 +125,7 @@ export const init = ({
.then(tableRoot => {
// Always update the toggle state.
// This ensures that the bulk actions are disabled after changing the page size.
CheckboxToggleAll.setGroupState(tableRoot, 'participants-table', checkCountButtonClicked);
CheckboxToggleAll.setGroupState(root, 'participants-table', checkCountButtonClicked);
return tableRoot;
})
@@ -144,7 +144,7 @@ export const init = ({
const currentPageSize = parseInt(tableRoot.dataset.tablePageSize, 10);
const totalRowCount = parseInt(tableRoot.dataset.tableTotalRows, 10);
CheckboxToggleAll.updateSlavesFromMasterState(tableRoot, 'participants-table');
CheckboxToggleAll.updateSlavesFromMasterState(root, 'participants-table');
const pageCountStrings = [
{
user/tests/behat/view_participants.feature
+2
View File
@@ -180,6 +180,7 @@ Feature: View course participants
And the field "Select 'Student 18x'" matches value "0"
And the field "Select 'Student 19x'" matches value "0"
# Pressing the "Select all X users" button should select all including the 21st user (Student 9x).
And I press "Select all 21 users"
And I should see "Student 9x"
And the field "Select 'Teacher 1x'" matches value "1"
@@ -204,6 +205,7 @@ Feature: View course participants
And the field "Select 'Student 17x'" matches value "1"
And the field "Select 'Student 18x'" matches value "1"
And the field "Select 'Student 19x'" matches value "1"
And the "With selected users..." "select" should be enabled
And I click on "Deselect all" "checkbox"
And the field "Select 'Teacher 1x'" matches value "0"