L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-42167 Update workshop assessment record only when really changed

Browse Source 
Under certain conditions there is nothing to actually update here. The
$DB->update_record() would throw an exception here.
This commit is contained in:
Matteo Scaramuccia
2013-10-10 10:12:07 +02:00
committed by David Mudrák
parent 22084d5ea2
commit 22b70ca985
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/workshop/assessment.php
+4 -1
View File
@@ -188,7 +188,10 @@ if (is_null($assessment->grade) and !$assessmenteditable) {
if (isset($data->weight) and $cansetassessmentweight) {
$coredata->weight = $data->weight;
}
$DB->update_record('workshop_assessments', $coredata);
// Update the assessment data if there is something other than just the 'id'.
if (count((array)$coredata) > 1 ) {
$DB->update_record('workshop_assessments', $coredata);
}
// And finally redirect the user's browser.
if (!is_null($rawgrade) and isset($data->saveandclose)) {
mod/workshop/exassessment.php
+4 -1
View File
@@ -126,7 +126,10 @@ if ($mform->is_cancelled()) {
// Remember the last one who edited the reference assessment.
$coredata->reviewerid = $USER->id;
}
$DB->update_record('workshop_assessments', $coredata);
// Update the assessment data if there is something other than just the 'id'.
if (count((array)$coredata) > 1 ) {
$DB->update_record('workshop_assessments', $coredata);
}
if (!is_null($rawgrade) and isset($data->saveandclose)) {
if ($canmanage) {