L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-33434 mssql: Improve handling of returned ids on insert.

Browse Source 
This commit moves from the batch SCOPE_IDENTITY() way to return
the inserted ids to the OUTPUT alternative (supported and
recommended since 2005). Also the handling of possible return
values is improved, with all the alternatives leading to expected results.
This commit is contained in:
Eloy Lafuente (stronk7)
2012-05-31 01:44:45 +02:00
parent 514da614c3
commit 21bb3f9466
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/dml/mssql_native_moodle_database.php
+16 -5
View File
@@ -810,7 +810,7 @@ class mssql_native_moodle_database extends moodle_database {
} else {
unset($params['id']);
if ($returnid) {
$returning = "; SELECT SCOPE_IDENTITY()";
$returning = "OUTPUT inserted.id";
}
}
@@ -822,18 +822,29 @@ class mssql_native_moodle_database extends moodle_database {
$qms = array_fill(0, count($params), '?');
$qms = implode(',', $qms);
$sql = "INSERT INTO {" . $table . "} ($fields) VALUES($qms) $returning";
$sql = "INSERT INTO {" . $table . "} ($fields) $returning VALUES ($qms)";
list($sql, $params, $type) = $this->fix_sql_params($sql, $params);
$rawsql = $this->emulate_bound_params($sql, $params);
$this->query_start($sql, $params, SQL_QUERY_INSERT);
$result = mssql_query($rawsql, $this->mssql);
$this->query_end($result);
// Expected results are:
// - true: insert ok and there isn't returned information.
// - false: insert failed and there isn't returned information.
// - resource: insert executed, need to look for returned (output)
// values to know if the insert was ok or no. Posible values
// are false = failed, integer = insert ok, id returned.
$end = false;
if (is_bool($result)) {
$end = $result;
} else if (is_resource($result)) {
$end = mssql_result($result, 0, 0); // Fetch 1st column from 1st row.
}
$this->query_end($end); // End the query with the calculated $end.
if ($returning !== "") {
$row = mssql_fetch_assoc($result);
$params['id'] = reset($row);
$params['id'] = $end;
}
$this->free_result($result);