MDL-55027 enrol_lti: avoid invalid image URL causing an exception

2016-06-27 13:29:17 +08:00
parent a7221c5f19
commit 20ede33d61
1 changed files with 4 additions and 2 deletions
@@ -202,8 +202,10 @@ class helper {
            'connecttimeout' => 5
        );

-        if (!$iconfiles = $fs->create_file_from_url($filerecord, $url, $urlparams)) {
-            return self::PROFILE_IMAGE_UPDATE_FAILED;
+        try {
+            $fs->create_file_from_url($filerecord, $url, $urlparams);
+        } catch (\file_exception $e) {
+            return get_string($e->errorcode, $e->module, $e->a);
        }

        $iconfile = $fs->get_area_files($context->id, 'user', 'newicon', false, 'itemid', false);